From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/ili9225: Use regular atomic helpers; drop simple-display helpers Date: Sun, 22 Mar 2026 04:15:34 +1000 Message-ID: In-Reply-To: <20260319160110.109610-7-tzimmermann@suse.de> References: <20260319160110.109610-1-tzimmermann@suse.de> <20260319160110.109610-7-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This driver has a custom `ili9225_fb_dirty()` and custom disable, so it nee= ds its own plane update and CRTC disable helpers. The conversion correctly = preserves the custom dirty function and custom power-down sequence. Note that the custom `ili9225_plane_helper_atomic_update()` doesn't match t= he pattern of the generic `drm_mipi_dbi_plane_helper_atomic_update()` =E2= =80=94 it calls `drm_dev_enter/exit` outside the damage check conditional r= ather than nesting them. This preserves the original behavior and is fine. No issues found. --- Generated by Claude Code Patch Reviewer