From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: use Coherent::init to initialize GspFwWprMeta
Date: Sun, 22 Mar 2026 03:23:43 +1000 [thread overview]
Message-ID: <review-patch6-20260320194626.36263-7-dakr@kernel.org> (raw)
In-Reply-To: <20260320194626.36263-7-dakr@kernel.org>
Patch Review
Converts `GspFwWprMeta` from a tuple struct `(bindings::GspFwWprMeta)` to a named-field struct `{ inner: bindings::GspFwWprMeta }` to enable `init!()` macro usage. The `new()` method now returns `impl Init<Self>` instead of `Self`.
**`..Zeroable::init_zeroed()` usage**: The `init!()` macro uses this for default-initialization of unspecified fields. This replaces `..Default::default()` which was used when constructing values directly. This is the correct pattern for pin-init.
Clean conversion. The `#[allow(non_snake_case)]` is needed because bindgen-generated field names use camelCase.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 17:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 19:45 [PATCH v2 0/8] dma::Coherent & dma::CoherentBox API Danilo Krummrich
2026-03-20 19:45 ` [PATCH v2 1/8] rust: dma: use "kernel vertical" style for imports Danilo Krummrich
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 2/8] rust: dma: add generalized container for types other than slices Danilo Krummrich
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 3/8] rust: dma: add zeroed constructor to `Coherent` Danilo Krummrich
2026-03-21 6:37 ` Alexandre Courbot
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 4/8] rust: dma: introduce dma::CoherentBox for memory initialization Danilo Krummrich
2026-03-20 20:55 ` Gary Guo
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 5/8] rust: dma: add Coherent:init() and Coherent::init_with_attrs() Danilo Krummrich
2026-03-20 20:56 ` Gary Guo
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 6/8] gpu: nova-core: use Coherent::init to initialize GspFwWprMeta Danilo Krummrich
2026-03-20 21:04 ` Gary Guo
2026-03-21 17:23 ` Claude Code Review Bot [this message]
2026-03-20 19:45 ` [PATCH v2 7/8] gpu: nova-core: convert Gsp::new() to use CoherentBox Danilo Krummrich
2026-03-20 21:06 ` Gary Guo
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 8/8] gpu: nova-core: convert to new dma::Coherent API Danilo Krummrich
2026-03-21 16:50 ` Gary Guo
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-21 5:13 ` [PATCH v2 0/8] dma::Coherent & dma::CoherentBox API Alexandre Courbot
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-03 16:22 [PATCH 0/8] dma::Coherent & dma::CoherentInit API Danilo Krummrich
2026-03-03 16:22 ` [PATCH 6/8] gpu: nova-core: use Coherent::init to initialize GspFwWprMeta Danilo Krummrich
2026-03-03 21:03 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260320194626.36263-7-dakr@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox