From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: use Coherent::init to initialize GspFwWprMeta
Date: Sun, 22 Mar 2026 03:23:43 +1000
Message-ID: <review-patch6-20260320194626.36263-7-dakr@kernel.org>
In-Reply-To: <20260320194626.36263-7-dakr@kernel.org>
References: <20260320194626.36263-1-dakr@kernel.org> <20260320194626.36263-7-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Converts `GspFwWprMeta` from a tuple struct `(bindings::GspFwWprMeta)` to a named-field struct `{ inner: bindings::GspFwWprMeta }` to enable `init!()` macro usage. The `new()` method now returns `impl Init<Self>` instead of `Self`.

**`..Zeroable::init_zeroed()` usage**: The `init!()` macro uses this for default-initialization of unspecified fields. This replaces `..Default::default()` which was used when constructing values directly. This is the correct pattern for pin-init.

Clean conversion. The `#[allow(non_snake_case)]` is needed because bindgen-generated field names use camelCase.

---
Generated by Claude Code Patch Reviewer