From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Date: Sun, 22 Mar 2026 03:00:54 +1000 Message-ID: In-Reply-To: <20260321-rimob-new-features-v3-6-d4b8ee867de7@protonmail.com> References: <20260321-rimob-new-features-v3-0-d4b8ee867de7@protonmail.com> <20260321-rimob-new-features-v3-6-d4b8ee867de7@protonmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean patch adding a hall effect sensor as an `SW_LID` event under the existing `gpio-keys` node. The pinctrl is added correctly with `bias-disable` (external pull-up presumably on the board). **Minor style note:** The pinctrl node name uses underscores (`gpio_hall_sensor_default`) while the DT convention now prefers hyphens (and indeed the label in the node name `gpio-hall-sensor-default-state` uses hyphens). This is consistent with the existing `gpio_key_default` in the base file though, so it's not a regression. Already has Reviewed-by from Konrad. No issues. --- Generated by Claude Code Patch Reviewer