From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: dw-hdmi: warn on unsupported attach combination
Date: Tue, 31 Mar 2026 16:54:44 +1000
Message-ID: <review-patch6-20260330-drm-lcdif-dbanc-v2-6-c7f2af536a24@bootlin.com>
In-Reply-To: <20260330-drm-lcdif-dbanc-v2-6-c7f2af536a24@bootlin.com>
References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> <20260330-drm-lcdif-dbanc-v2-6-c7f2af536a24@bootlin.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

```c
if (WARN_ON((flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) && !hdmi->plat_data->o=
utput_port))
    return -EINVAL;
```

The WARN_ON is appropriate =E2=80=94 this is a programming error (driver mi=
sconfiguration), not a runtime condition. Good.

---
Generated by Claude Code Patch Reviewer