From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: Move repeated job fence check to its own function Date: Tue, 31 Mar 2026 17:33:25 +1000 Message-ID: In-Reply-To: <20260330-job-submission-fixes-cleanup-v1-6-7de8c09cef8c@imgtec.com> References: <20260330-job-submission-fixes-cleanup-v1-0-7de8c09cef8c@imgtec.com> <20260330-job-submission-fixes-cleanup-v1-6-7de8c09cef8c@imgtec.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status**: Good refactor. Extracts the `f->ops == &pvr_queue_job_fence_ops` check into a new `pvr_queue_fence_is_ufo_backed()` (static, internal) helper, used in both `to_pvr_queue_job_fence()` and `pvr_queue_fence_is_native()`. The naming is clear and the doc comment is accurate. Note: this reintroduces `pvr_queue_fence_is_ufo_backed` as a *static* function after patch 4 renamed the *exported* one. The static one checks if a raw `dma_fence` has the job fence ops (UFO-backed), while the exported `pvr_queue_fence_is_native()` checks if it's a scheduler fence from this driver. Different scopes, different purposes - no confusion. **No issues.** --- Generated by Claude Code Patch Reviewer