From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Date: Wed, 01 Apr 2026 07:57:45 +1000 Message-ID: In-Reply-To: <20260331-rimob-new-features-v5-6-5fcf42a29c12@protonmail.com> References: <20260331-rimob-new-features-v5-0-5fcf42a29c12@protonmail.com> <20260331-rimob-new-features-v5-6-5fcf42a29c12@protonmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean addition of hall effect sensor as a gpio-keys child with `SW_LID` event type. The pinctrl states under `&tlmm` are now sorted by GPIO index (46, 61, 64-65, 85) as requested by reviewers in v5 changelog. No issues. --- **Summary of items requiring action:** 1. **Patch 3 (bug):** DTS panel `compatible` must include the fallback `"novatek,nt35532"` to match the binding schema. 2. **Patch 2 (minor):** Consider using `mipi_dsi_dcs_exit_sleep_mode_multi()` / `mipi_dsi_dcs_set_display_on_multi()` instead of generic writes for the standard DCS commands in `rimob_panel_on()`, for consistency with the off path. --- Generated by Claude Code Patch Reviewer