From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: dw-hdmi: warn on unsupported attach combination
Date: Sun, 12 Apr 2026 13:37:34 +1000
Message-ID: <review-patch6-20260407-drm-lcdif-dbanc-v4-6-247a16e61ef9@bootlin.com>
In-Reply-To: <20260407-drm-lcdif-dbanc-v4-6-247a16e61ef9@bootlin.com>
References: <20260407-drm-lcdif-dbanc-v4-0-247a16e61ef9@bootlin.com> <20260407-drm-lcdif-dbanc-v4-6-247a16e61ef9@bootlin.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

```c
+	/* DRM_BRIDGE_ATTACH_NO_CONNECTOR requires a remote-endpoint to the next bridge */
+	if (WARN_ON((flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) && !hdmi->plat_data->output_port))
+		return -EINVAL;
```

Good defensive check. The `WARN_ON` is appropriate here since this would indicate a driver programming error (requesting NO_CONNECTOR mode without configuring an output port). The early return with `-EINVAL` is correct.

No issues.

---

---
Generated by Claude Code Patch Reviewer