From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: lib/fonts: Refactor glyph-pattern helpers Date: Sun, 12 Apr 2026 13:55:02 +1000 Message-ID: In-Reply-To: <20260407092555.58816-7-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> <20260407092555.58816-7-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Clean refactor.** Introduces `__font_glyph_pos()` to centralize the bit position calculation, plus `font_glyph_test_bit()` and `font_glyph_set_bit()`. The new helpers change signatures from `(x, y, pitch, pat)` to `(glyph, x, y, bit_pitch)` -- buffer-first, consistent with other `font_glyph_*` APIs. The refactoring is purely mechanical. The rotation functions themselves are updated to call the new helpers but the bit manipulation logic is unchanged. Verified that the coordinate computations in all three rotation functions remain identical. No issues. --- --- Generated by Claude Code Patch Reviewer