From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/dp: Add a helper to get the SDP type as a string Date: Sun, 12 Apr 2026 12:51:26 +1000 Message-ID: In-Reply-To: <20260408084239.1295325-7-ankit.k.nautiyal@intel.com> References: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com> <20260408084239.1295325-7-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `dp_sdp_type_get_name()` and uses it in both `drm_dp_vsc_sdp_log()` and `drm_dp_as_sdp_log()`. The function covers the common SDP types. Concern: If `vsc->sdp_type` or `as_sdp->sdp_type` was never set (e.g. old code paths that don't populate sdp_type), this would print "Unknown" instead of the previous hardcoded "VSC" / "AS_SDP". This is mitigated by patch 14 which sets sdp_type in the unpack path, but there could be a window between patches 6 and 14 where readback prints "Unknown" for AS SDP. Missing R-b. --- Generated by Claude Code Patch Reviewer