From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: Add DOORBELL_BLOCK registers Date: Sun, 12 Apr 2026 10:45:09 +1000 Message-ID: In-Reply-To: <20260409-b4-tyr-use-register-macro-v5-v5-6-8abfff8a0204@collabora.com> References: <20260409-b4-tyr-use-register-macro-v5-v5-0-8abfff8a0204@collabora.com> <20260409-b4-tyr-use-register-macro-v5-v5-6-8abfff8a0204@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds definitions for the doorbell register array. ```rust pub(crate) const NUM_DOORBELLS: usize = 64; const STRIDE: usize = 0x10000; register! { pub(crate) DOORBELL(u32)[NUM_DOORBELLS, stride = STRIDE] @ 0x80000 { 0:0 ring => bool; } } ``` 64 doorbells at 64KiB stride starting at 0x80000. Each doorbell block occupies a full page to allow per-doorbell memory mapping. The single `ring` bit is write-only (documented in the comment). This is forward-looking infrastructure for future CSF support. No issues. --- **Summary:** The series is in good shape. The main actionable item is that the `L2_PWRTRANS_HI` offset fix (0x204 -> 0x224) in patch 1 should be called out explicitly in the commit message since it fixes a real bug, not just a naming issue. The rest is clean, well-documented, and correct against the panthor C reference. --- Generated by Claude Code Patch Reviewer