From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: hdmi-state-helper: Act on color format DRM property Date: Sun, 12 Apr 2026 11:01:41 +1000 Message-ID: In-Reply-To: <20260409-color-format-v12-6-ce84e1817a27@collabora.com> References: <20260409-color-format-v12-0-ce84e1817a27@collabora.com> <20260409-color-format-v12-6-ce84e1817a27@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Modifies `hdmi_compute_config()` to handle explicit color format requests: ```c if (conn_state->color_format != DRM_CONNECTOR_COLOR_FORMAT_AUTO) { switch (conn_state->color_format) { case DRM_CONNECTOR_COLOR_FORMAT_AUTO: drm_warn(connector->dev, "AUTO format in non-AUTO path.\n"); fallthrough; case DRM_CONNECTOR_COLOR_FORMAT_RGB444: fmt = DRM_OUTPUT_COLOR_FORMAT_RGB444; break; ``` The `DRM_CONNECTOR_COLOR_FORMAT_AUTO` case inside the `!= AUTO` guard is deliberately unreachable but exists to satisfy compiler warnings about unhandled enum values. The `drm_warn` + `fallthrough` is a reasonable defensive pattern. Some reviewers might prefer an `unreachable()` or `WARN_ON_ONCE(1)` here instead, but the approach is acceptable. R-b from Dmitry Baryshkov and Maxime Ripard. **Verdict**: Good. --- --- Generated by Claude Code Patch Reviewer