From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: usb: typec: ucsi: huawei-gaokun: pass down HPD_IRQ events Date: Thu, 23 Apr 2026 09:32:10 +1000 Message-ID: In-Reply-To: <20260420-hpd-irq-events-v2-6-402ffe27e9e9@oss.qualcomm.com> References: <20260420-hpd-irq-events-v2-0-402ffe27e9e9@oss.qualcomm.com> <20260420-hpd-irq-events-v2-6-402ffe27e9e9@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Same pattern as patch 5, converting the Huawei Gaokun UCSI driver: ```c drm_aux_hpd_bridge_notify_extra(&port->bridge->dev, port->hpd_state ? connector_status_connected : connector_status_disconnected, port->hpd_irq ? DRM_CONNECTOR_DP_IRQ_HPD : DRM_CONNECTOR_NO_EXTRA_STATUS); ``` **Looks correct.** Has appropriate Reviewed-by and Acked-by tags. --- **Summary:** The series needs a v3 to fix the **compile-breaking semicolon bug** in patch 3's `aux-bridge.h` stub, and the spurious blank line removal in patch 2 should be dropped. The overall design is sound and the approach of using an enum for extra status is good for extensibility. The concern about `drm_bridge_connector_handle_hpd()` unconditionally firing userspace hotplug events for IRQ_HPD-only notifications is worth discussing but isn't a blocker. --- Generated by Claude Code Patch Reviewer