From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: Make msm_framebuffer_init() an internal interface again Date: Thu, 23 Apr 2026 08:30:54 +1000 Message-ID: In-Reply-To: <20260421125733.209568-7-tzimmermann@suse.de> References: <20260421125733.209568-1-tzimmermann@suse.de> <20260421125733.209568-7-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good.** This correctly reverses patch 1 =E2=80=94 removes the declaration from `msm= _drv.h` and re-adds the `static` qualifier. After patch 5, `msm_fbdev.c` no= longer calls `msm_framebuffer_init()` directly (it goes through `drm_clien= t_buffer_create()` which uses the ADDFB2 path), so the only caller is `msm_= framebuffer_create()` in the same file. Clean bookend to the series. --- Generated by Claude Code Patch Reviewer