From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: mm: Add common memory management types
Date: Tue, 28 Apr 2026 15:32:00 +1000 [thread overview]
Message-ID: <review-patch6-20260425211454.174696-7-joelagnelf@nvidia.com> (raw)
In-Reply-To: <20260425211454.174696-7-joelagnelf@nvidia.com>
Patch Review
Introduces `VramAddress`, `VirtualAddress`, `Pfn`, `Vfn` foundational types with bitfield decomposition. Clean use of Rust's type system.
**Minor — `PAGE_SIZE` naming:** The constant `pub(crate) const PAGE_SIZE: usize = SZ_4K` shadows the kernel's CPU `PAGE_SIZE`. A name like `GPU_PAGE_SIZE` would avoid confusion, especially on architectures where CPU page size differs from 4K.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 5:32 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 21:14 [PATCH v12 00/22] gpu: nova-core: Add memory management support Joel Fernandes
2026-04-25 21:14 ` [PATCH v12 01/22] gpu: nova-core: gsp: Return GspStaticInfo from boot() Joel Fernandes
2026-04-28 5:31 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 02/22] gpu: nova-core: gsp: Extract usable FB region from GSP Joel Fernandes
2026-04-28 5:31 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 03/22] gpu: nova-core: gsp: Expose total physical VRAM end from FB region info Joel Fernandes
2026-04-28 5:31 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 04/22] gpu: nova-core: mm: Add support to use PRAMIN windows to write to VRAM Joel Fernandes
2026-04-28 5:31 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 05/22] docs: gpu: nova-core: Document the PRAMIN aperture mechanism Joel Fernandes
2026-04-28 5:31 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 06/22] gpu: nova-core: mm: Add common memory management types Joel Fernandes
2026-04-28 5:32 ` Claude Code Review Bot [this message]
2026-04-25 21:14 ` [PATCH v12 07/22] gpu: nova-core: mm: Add TLB flush support Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 08/22] gpu: nova-core: mm: Add GpuMm centralized memory manager Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 09/22] gpu: nova-core: mm: Add common types for all page table formats Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 10/22] gpu: nova-core: mm: Add MMU v2 page table types Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 11/22] gpu: nova-core: mm: Add MMU v3 " Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 12/22] gpu: nova-core: mm: Add page table entry operation traits Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 13/22] gpu: nova-core: mm: Add page table walker for MMU v2/v3 Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 14/22] gpu: nova-core: mm: Add Virtual Memory Manager Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 15/22] gpu: nova-core: mm: Add virtual address range tracking to VMM Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 16/22] gpu: nova-core: mm: Add multi-page mapping API " Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 17/22] gpu: nova-core: Add BAR1 aperture type and size constant Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 18/22] gpu: nova-core: mm: Add BAR1 user interface Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 19/22] gpu: nova-core: mm: Add BAR1 memory management self-tests Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 20/22] gpu: nova-core: mm: Add PRAMIN aperture self-tests Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 21/22] gpu: nova-core: mm: pramin: drop useless as_ref() in run_self_test Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-25 21:14 ` [PATCH v12 22/22] rust: maple_tree: implement Send and Sync for MapleTree Joel Fernandes
2026-04-28 5:32 ` Claude review: " Claude Code Review Bot
2026-04-28 5:31 ` Claude review: gpu: nova-core: Add memory management support Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-11 0:39 [PATCH v9 00/23] " Joel Fernandes
2026-03-11 0:39 ` [PATCH v9 08/23] gpu: nova-core: mm: Add common memory management types Joel Fernandes
2026-03-31 21:33 ` Claude review: " Claude Code Review Bot
2026-02-24 22:52 [PATCH v8 00/25] gpu: nova-core: Add memory management support Joel Fernandes
2026-02-24 22:53 ` [PATCH v8 08/25] gpu: nova-core: mm: Add common memory management types Joel Fernandes
2026-02-27 4:25 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260425211454.174696-7-joelagnelf@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox