From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: shuffle boot code a bit to keep chipset-specific parts close Date: Tue, 28 Apr 2026 15:01:48 +1000 Message-ID: In-Reply-To: <20260427-nova-unload-v4-6-e145ccddae66@nvidia.com> References: <20260427-nova-unload-v4-0-e145ccddae66@nvidia.com> <20260427-nova-unload-v4-6-e145ccddae66@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **This patch has a meaningful behavioral change despite the commit message = saying "no effect on the GSP boot process."** The `wpr_meta` allocation is moved earlier (before FWSEC-FRTS), which is fi= ne. But critically, `SetSystemInfo` and `SetRegistry` command sends are mov= ed from **before** the GSP falcon boot to **after** the RISC-V active poll: ```rust - self.cmdq - .send_command_no_wait(bar, commands::SetSystemInfo::new(pdev))= ?; - self.cmdq - .send_command_no_wait(bar, commands::SetRegistry::new())?; - gsp_falcon.reset(bar)?; ... + self.cmdq + .send_command_no_wait(bar, commands::SetSystemInfo::new(pdev))= ?; + self.cmdq + .send_command_no_wait(bar, commands::SetRegistry::new())?; ``` These are `send_command_no_wait` calls that enqueue commands for the GSP to= process. Previously they were enqueued before the GSP falcon was booted (w= hich implies the command queue is written to shared memory that the GSP rea= ds after boot). Now they're sent after RISC-V is confirmed active. **This ordering change could matter** =E2=80=94 if the GSP reads the comman= d queue immediately upon becoming active, the commands might not be there y= et in the new ordering. However, since the sequencer runs after these comma= nds (and the sequencer itself triggers GSP processing), this is likely safe= . But the commit message should acknowledge this is a behavioral change, no= t just a shuffle. Worth a comment from the author on whether this reordering was tested and i= s intentional. --- --- Generated by Claude Code Patch Reviewer