From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: rockchip: Add Anbernic RG Vita-Pro
Date: Tue, 28 Apr 2026 14:19:03 +1000
Message-ID: <review-patch6-20260427170914.5062-7-macroalpha82@gmail.com>
In-Reply-To: <20260427170914.5062-7-macroalpha82@gmail.com>
References: <20260427170914.5062-1-macroalpha82@gmail.com> <20260427170914.5062-7-macroalpha82@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Unrelated Makefile entries:**
The Makefile hunk adds two entries unrelated to this series:

```
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-indiedroid-nova-tower.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-indiedroid-nova-test.dtb
```

These should be in a separate patch or dropped. The `rk3588s-indiedroid-nova-test.dtb` name suggests a test file that shouldn't be in a mainline submission.

**`constant-charge-current-max-microamp` in battery node is 10A:**

```dts
		constant-charge-current-max-microamp = <10000000>;
```

The SGM41542 hardware maximum charge current is 3.78A. This BSP value will be clamped by the driver, but it's misleading to specify a value the hardware can't deliver. It should reflect the actual intended charge current.

**`chassis-type = "handset"`** seems wrong for a handheld gaming device. Consider `"handset"` vs a more appropriate type. While there's no perfect fit in the DT spec for a gaming handheld, `"handset"` typically implies a phone. This may be acceptable as the closest match.

**Bluetooth compatible:**

```dts
		compatible = "realtek,rtl8822cs-bt";
```

The cover letter says the WiFi chip is RTL8852BE, not RTL8822CS. Verify the Bluetooth compatible string matches the actual hardware.

**The `sdio` node has `no-sdio` set:**

```dts
&sdio {
	...
	no-sdio;
```

An SD/MMC node named `sdio` with `no-sdio` is confusing but presumably correct if the hardware muxes this as a second SD slot rather than SDIO.

**Minor: extra space in `try-power-role`:**

```dts
			try-power-role  = "sink";
```

Two spaces before `=`. Should be one.

---
Generated by Claude Code Patch Reviewer