From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: Add out-of-band HPD notify handler Date: Tue, 05 May 2026 09:49:47 +1000 Message-ID: In-Reply-To: <20260501-synopsys-dw-dp-improvements-v2-6-d7e7f6bac77f@collabora.com> References: <20260501-synopsys-dw-dp-improvements-v2-0-d7e7f6bac77f@collabora.com> <20260501-synopsys-dw-dp-improvements-v2-6-d7e7f6bac77f@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds a new `oob_notify` callback to `struct drm_bridge_funcs` and calls it = from `drm_bridge_connector_oob_hotplug_event()` for every bridge in the cha= in. ```c + void (*oob_notify)(struct drm_bridge *bridge, + struct drm_connector *connector, + enum drm_connector_status status); ``` **Design question (acknowledged by author):** The cover letter mentions thi= s might not be the ideal solution. The concern is valid =E2=80=94 `oob_hotp= lug_event` already calls `drm_bridge_connector_handle_hpd()` which goes thr= ough `hpd_notify`. Having a separate `oob_notify` that fires before the exi= sting `hpd_notify` flow creates two notification paths. The rationale (OOB = needs to force HPD state before `.detect` runs) is sound, but this should b= e discussed with DRM bridge maintainers (Dmitry Baryshkov is already CC'd). **Minor:** The iteration uses `drm_for_each_bridge_in_chain_scoped` which n= otifies *all* bridges, but only the DP controller bridge will actually impl= ement `oob_notify`. This is fine =E2=80=94 the callback check handles it. --- Generated by Claude Code Patch Reviewer