From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: Add a6xx+ perfcntr tables
Date: Tue, 05 May 2026 08:06:02 +1000
Message-ID: <review-patch6-20260504190751.61052-7-robin.clark@oss.qualcomm.com>
In-Reply-To: <20260504190751.61052-7-robin.clark@oss.qualcomm.com>
References: <20260504190751.61052-1-robin.clark@oss.qualcomm.com> <20260504190751.61052-7-robin.clark@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Wires up the generated perfcntr tables. The family range checks look correc=
t:

```c
if ((ADRENO_6XX_GEN1 <=3D config->info->family) &&
    (config->info->family <=3D ADRENO_6XX_GEN4)) {
```

Minor style nit: the outer parentheses around each condition in the `if` ar=
e unnecessary per kernel style but harmless.

The `msm_perfcntr.h` header introduces the `msm_perfcntr_group` struct with=
 `name`, `pipe`, `num_counters`, `num_countables`, `countables`, and `count=
ers` =E2=80=94 the foundation for everything else. Looks clean.

---
Generated by Claude Code Patch Reviewer