From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: iris: don't specify max_channels in the source code Date: Thu, 07 May 2026 12:40:18 +1000 Message-ID: In-Reply-To: <20260507-iris-ubwc-v5-6-e9a3aee53c49@oss.qualcomm.com> References: <20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com> <20260507-iris-ubwc-v5-6-e9a3aee53c49@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Replaces `core->iris_platform_data->ubwc_config->max_channels` (hardcoded t= o 8 for SM8550) with: ```c payload =3D qcom_ubwc_macrotile_mode(ubwc) ? 8 : 4; ``` Per the UBWC header documentation: macrotile_mode `0` means 4-channel, `1` = means 8-channel (introduced in UBWC 3.1). SM8550 with its UBWC 4.x would us= e 8-channel macrotiling, so `macrotile_mode` is true =E2=86=92 8. Matches t= he original. No issues. --- Generated by Claude Code Patch Reviewer