From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Reject invalid syncobj handles in submit ioctls Date: Sat, 16 May 2026 15:59:28 +1000 Message-ID: In-Reply-To: <20260510-v3d-sched-misc-fixes-v2-6-ca4aba343ef6@igalia.com> References: <20260510-v3d-sched-misc-fixes-v2-0-ca4aba343ef6@igalia.com> <20260510-v3d-sched-misc-fixes-v2-6-ca4aba343ef6@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Good fix. Previously, `-ENOENT` from `drm_sched_job_add_syncobj_dependency(= )` was silently swallowed for both zero and non-zero handles. Now zero hand= les are skipped (no dependency to add), and non-zero invalid handles proper= ly propagate the error. **Minor note on UAPI compatibility**: Userspace that previously passed non-= zero invalid in_sync handles and relied on silent success will now get `-EN= OENT`. This is the correct behavior but is technically a UAPI change. The c= ommit message acknowledges this is a "userspace bug" scenario, and this see= ms like the right call =E2=80=94 silently ignoring broken handles masks rea= l bugs. No issues. --- Generated by Claude Code Patch Reviewer