From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_hdmi: Remove empty encoder helper funcs Date: Sat, 16 May 2026 16:14:39 +1000 Message-ID: In-Reply-To: <20260510183114.1248840-7-jonas@kwiboo.se> References: <20260510183114.1248840-1-jonas@kwiboo.se> <20260510183114.1248840-7-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Clean** Removes the empty `dw_hdmi_rockchip_encoder_disable()` and the always-true `dw_hdmi_rockchip_encoder_mode_fixup()`. The DRM core already handles these cases: a NULL `disable` callback is a no-op, and a NULL `mode_fixup` defaults to true. The whitespace alignment cleanup in the helper funcs struct (removing extra spaces for alignment) is a reasonable companion change. No issues. --- --- Generated by Claude Code Patch Reviewer