From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/damage-helper: Remove old state from drm_atomic_helper_damage_iter_init() Date: Sat, 16 May 2026 15:34:45 +1000 Message-ID: In-Reply-To: <20260511122421.114014-7-tzimmermann@suse.de> References: <20260511122421.114014-1-tzimmermann@suse.de> <20260511122421.114014-7-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correctness**: Straightforward and correct. Since the src coordinate comparison was moved to check time in patch 4, `damage_iter_init` no longer needs the old state at all. The `old_state` parameter is removed and all ~20 callers are updated. This is a mechanical mass-conversion. All call sites I can verify look correct -- they simply drop the old_state argument. The test changes are consistent: `mock->old_state` is removed from the mock struct and all `set_plane_src(&mock->old_state, ...)` calls are dropped. --- Generated by Claude Code Patch Reviewer