From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: Add a6xx+ perfcntr tables
Date: Sat, 16 May 2026 15:20:23 +1000
Message-ID: <review-patch6-20260511130017.96867-7-robin.clark@oss.qualcomm.com>
In-Reply-To: <20260511130017.96867-7-robin.clark@oss.qualcomm.com>
References: <20260511130017.96867-1-robin.clark@oss.qualcomm.com> <20260511130017.96867-7-robin.clark@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Wires up generated perfcntr tables per GPU family in `a6xx_gpu_init`. The family range checks look correct. One observation:

```c
if ((ADRENO_6XX_GEN1 <= config->info->family) &&
    (config->info->family <= ADRENO_6XX_GEN4)) {
```

Future GPU generations (beyond 8XX_GEN2) will silently get no perfcntr tables. A `WARN_ON(!gpu->perfcntr_groups)` after the chain might be nice as a reminder, but it's fine to leave as-is since adding new GPU support always requires code changes.

---
Generated by Claude Code Patch Reviewer