From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: renesas: vsp1: Use mutex scoped guards Date: Sat, 16 May 2026 14:29:49 +1000 Message-ID: In-Reply-To: <20260511235637.3468558-7-laurent.pinchart+renesas@ideasonboard.com> References: <20260511235637.3468558-1-laurent.pinchart+renesas@ideasonboard.com> <20260511235637.3468558-7-laurent.pinchart+renesas@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Converts remaining mutex lock/unlock pairs to `scoped_guard(mutex, ...)` wh= ere the lock doesn't cover to end-of-function. This enables early returns f= rom within the guarded scope. The key conversions: - `vsp1_du_enable()`: multiple error returns inside `scoped_guard` =E2=80= =94 all correct, cleanup fires on scope exit. - `vsp1_du_disable()`: local `brx` variable moved into the scoped_guard blo= ck. - `vsp1_video_streamon()`: `goto err_pipe` inside `scoped_guard` =E2=80=94 = correct, the `__attribute__((cleanup))` fires when leaving the scope via go= to, releasing the mutex before reaching the `err_pipe:` label. - `vsp1_brx.c`, `vsp1_entity.c`, `vsp1_hgo.c`, `vsp1_hgt.c`: straightforwar= d scoped_guard wrapping small critical sections. **All correct.** --- Generated by Claude Code Patch Reviewer