From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: kaanapali: Add GPU cooling Date: Sat, 16 May 2026 14:35:14 +1000 Message-ID: In-Reply-To: <20260512-kaana-gpu-dt-v1-6-13e1c07c2050@oss.qualcomm.com> References: <20260512-kaana-gpu-dt-v1-0-13e1c07c2050@oss.qualcomm.com> <20260512-kaana-gpu-dt-v1-6-13e1c07c2050@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Minor inconsistency in gpuss-10-thermal** This patch modifies all 11 GPU thermal zones (gpuss-0 through gpuss-10) to = add passive cooling at 105=C2=B0C via the GPU cooling device. For zones 0-9= , it replaces the existing "hot" trip at 120=C2=B0C with a "passive" trip a= t 105=C2=B0C. The polling-delay-passive of 200ms and `THERMAL_NO_LIMIT` coo= ling limits are standard. **Inconsistency in gpuss-10-thermal:** Unlike zones 0-9 where the "hot" tri= p is *replaced* with a "passive" trip, zone 10 *adds* a new passive trip wh= ile *keeping* the "hot" trip: ```diff gpuss-10-thermal { + ... trips { + gpuss_10_alert0: gpuss-10-alert0 { + temperature =3D <105000>; + hysteresis =3D <5000>; + type =3D "passive"; + }; gpuss-10-hot { temperature =3D <120000>; hysteresis =3D <5000>; ``` For zones 0-9, the "hot" trip at 120=C2=B0C is removed and replaced with th= e "passive" trip at 105=C2=B0C (the critical trip at 125=C2=B0C remains). F= or zone 10, both the new "passive" at 105=C2=B0C AND the old "hot" at 120= =C2=B0C exist alongside the critical trip. This may be intentional if zone 10 has different thermal characteristics, b= ut it is inconsistent with the other zones. If zone 10 should be treated th= e same as 0-9, the "hot" trip should be replaced rather than supplemented. = Worth clarifying with the author. --- --- Generated by Claude Code Patch Reviewer