From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: kunit: provide kunit_software_node_register() Date: Sat, 16 May 2026 13:28:31 +1000 Message-ID: In-Reply-To: <20260512-swnode-remove-on-dev-unreg-v5-6-0035eff63812@oss.qualcomm.com> References: <20260512-swnode-remove-on-dev-unreg-v5-0-0035eff63812@oss.qualcomm.com> <20260512-swnode-remove-on-dev-unreg-v5-6-0035eff63812@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean implementation. The action-based cleanup pattern (`kunit_add_action_or_reset`) is idiomatic for kunit resource management. The `WARN_ON(!fwnode)` after a successful `software_node_register()` is a reasonable defensive check. No issues. --- Generated by Claude Code Patch Reviewer