From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/ras: Set error threshold support
Date: Sat, 16 May 2026 12:54:50 +1000
Message-ID: <review-patch6-20260512191610.1817578-7-raag.jadav@intel.com>
In-Reply-To: <20260512191610.1817578-7-raag.jadav@intel.com>
References: <20260512191610.1817578-1-raag.jadav@intel.com> <20260512191610.1817578-7-raag.jadav@intel.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Implements `xe_ras_set_threshold()` with the set-threshold mailbox command =
and adds RAS operation status codes.

**Positive: Good status code handling.** The `ras_status_to_errno()` functi=
on properly maps firmware status codes to standard errno values, including =
a catch-all `-EPROTO` for unexpected statuses.

**Minor: Stray semicolon after function definition.**

```c
static int ras_status_to_errno(u32 status)
{
    ...
    }
};   // <-- spurious semicolon
```

This compiles but is technically a stray empty declaration. Harmless but no=
t clean.

**Same bounds-checking concern as patch 5** applies to `xe_ras_set_threshol=
d()`.

**Observation: `get_threshold` does not check `response.status` but `set_th=
reshold` does.** If the firmware can return a non-zero status for get opera=
tions too, the get path may silently return garbage data. Worth checking wh=
ether the get response also has a status field =E2=80=94 looking at `xe_ras=
_get_threshold_response`, it does not have a `status` field, so this is fin=
e.

---

---
Generated by Claude Code Patch Reviewer