From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: glymur: Add GPU cooling Date: Sat, 16 May 2026 12:51:48 +1000 Message-ID: In-Reply-To: <20260513-glymur-gpu-dt-v4-6-f83832c3bc9a@oss.qualcomm.com> References: <20260513-glymur-gpu-dt-v4-0-f83832c3bc9a@oss.qualcomm.com> <20260513-glymur-gpu-dt-v4-6-f83832c3bc9a@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds passive thermal throttling to all 14 GPU thermal zones (gpu-0-0 throug= h gpu-3-2, plus gpuss-0 and gpuss-1). For each zone: - Adds `polling-delay-passive =3D <100>` (100ms polling when throttling) - Changes trip type from `"hot"` to `"passive"` (enables throttling) - Raises trip temperature from 90=C2=B0C to 95=C2=B0C - Reduces hysteresis from 5=C2=B0C to 1=C2=B0C - Adds cooling-map linking to the `&gpu` cooling device The `#include ` is correctly added for `THER= MAL_NO_LIMIT`. **Observation:** In the first thermal zone (`gpu-0-0-thermal`), the diff sh= ows the `cooling-maps` block is placed before `trips`, while the closing `}= ;` for the zone gets an extra blank line added before it. This is cosmetic = but slightly inconsistent with the original formatting. Not a blocker. The pattern is consistent across all 14 zones. Raising the threshold from 9= 0=C2=B0C to 95=C2=B0C while switching to passive (throttling) cooling is a = reasonable tradeoff =E2=80=94 the GPU throttles itself at 95=C2=B0C rather = than just logging at 90=C2=B0C. The 1=C2=B0C hysteresis (down from 5=C2=B0C= ) means the GPU will start ramping back up more quickly once temperature dr= ops below 94=C2=B0C, which is appropriate for passive throttling. No functional issues. --- Generated by Claude Code Patch Reviewer