From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: usb: typec: ucsi: huawei-gaokun: pass down HPD_IRQ events Date: Sat, 16 May 2026 11:25:51 +1000 Message-ID: In-Reply-To: <20260513-hpd-irq-events-v3-6-086857017f16@oss.qualcomm.com> References: <20260513-hpd-irq-events-v3-0-086857017f16@oss.qualcomm.com> <20260513-hpd-irq-events-v3-6-086857017f16@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Same pattern as patch 5, using `port->hpd_irq`. Has Reviewed-by and Acked-b= y tags. **No issues.** --- **Summary of concerns, in priority order:** 1. **Medium: `drm_bridge_connector_handle_hpd` fires full hotplug cycle on = IRQ_HPD** (patch 2) =E2=80=94 This will trigger `drm_kms_helper_connector_h= otplug_event()` for every DP sideband IRQ, which schedules a full detect cy= cle. For frequent MST events this could cause unnecessary overhead. The sta= tus assignment (`connector->status =3D status`) is also redundant when stat= us hasn't changed. Consider guarding the hotplug event behind a status-chan= ge check when only `extra_status` is set. 2. **Low: i915 `extra_status` is silently dropped** (patch 2) =E2=80=94 The= Intel driver ignores IRQ_HPD from USB-C. If this is intentional (deferred = to a follow-up), a comment would help. 3. **Nit: Stray whitespace removal in ti-tfp410.c** (patch 2) =E2=80=94 Dro= p the unrelated blank line removal. 4. **Nit: Typos** =E2=80=94 "keps" in patch 3 commit message, "singnalling"= in cover letter. --- Generated by Claude Code Patch Reviewer