From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: Add a6xx+ perfcntr tables
Date: Sat, 16 May 2026 10:50:09 +1000
Message-ID: <review-patch6-20260514134052.361771-7-robin.clark@oss.qualcomm.com>
In-Reply-To: <20260514134052.361771-7-robin.clark@oss.qualcomm.com>
References: <20260514134052.361771-1-robin.clark@oss.qualcomm.com> <20260514134052.361771-7-robin.clark@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Wires up generated perfcntr tables in `a6xx_gpu_init()` based on GPU family. The family range checks look correct:
```c
if ((ADRENO_6XX_GEN1 <= config->info->family) &&
    (config->info->family <= ADRENO_6XX_GEN4)) {
```
One minor observation: if future families are added between GEN4 and 7XX_GEN1, they would silently get no perfcntr support. The null-pointer guard in patch 13 (`if (!gpu || !gpu->num_perfcntr_groups) return -ENXIO`) handles this gracefully, so it's fine.

---
Generated by Claude Code Patch Reviewer