From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: use plane color_mgmt_changed to track colorop changes
Date: Mon, 25 May 2026 22:24:21 +1000
Message-ID: <review-patch6-20260519211111.228303-7-mwen@igalia.com>
In-Reply-To: <20260519211111.228303-7-mwen@igalia.com>
References: <20260519211111.228303-1-mwen@igalia.com> <20260519211111.228303-7-mwen@igalia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Looks good**

Driver-side consumption of the new `plane_state->color_mgmt_changed` flag i=
n two places in `amdgpu_dm.c`:

1. `amdgpu_dm_commit_planes`: Extends the existing CRTC `color_mgmt_changed=
` check to also trigger on plane-level changes:
```c
if (new_pcrtc_state->color_mgmt_changed || new_plane_state->color_mgmt_chan=
ged) {
```

2. `should_reset_plane`: Adds a new check that forces plane reset when colo=
r management changed:
```c
if (new_plane_state->color_mgmt_changed)
    return true;
```

Both are straightforward and correct. The comment "Plane color pipeline or =
its colorop changes." is acceptable. This patch fixes the actual user-visib=
le bug (gamescope night mode shaper/3D LUT updates not taking effect).

---

**Summary of required changes:**
- **Must fix**: Squash the `drm_colorop.c` syntax fixes from Patch 5 into P=
atch 4 to fix the build breakage and maintain bisectability. The two-charac=
ter changes (`));` =E2=86=92 `))` and `&val);` =E2=86=92 `&val))`) belong w=
here the code was introduced.

---
Generated by Claude Code Patch Reviewer