From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/sun4i: hdmi: Use the common TMDS char rate constant Date: Mon, 25 May 2026 21:45:02 +1000 Message-ID: In-Reply-To: <20260520144424.1633354-7-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> <20260520144424.1633354-7-javierm@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces the magic number 165000000 with `HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ` and fixes the comment: ```c - /* 165 MHz is the typical max pixelclock frequency for HDMI <= 1.2 */ - if (clock > 165000000) + /* HDMI 1.0 max TMDS character rate */ + if (clock > HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ) ``` The comment correction is accurate -- 165 MHz max TMDS char rate is from HDMI 1.0, not "HDMI <= 1.2". No explicit `#include ` added, but it's already available transitively via `drm_hdmi_helper.h`, which I verified. No issues. **Reviewed-by tag:** Chen-Yu Tsai. --- Generated by Claude Code Patch Reviewer