From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: driver core: platform: provide platform_device_set_of_node()
Date: Mon, 25 May 2026 20:33:08 +1000
Message-ID: <review-patch6-20260521-pdev-fwnode-ref-v1-6-88c324a1b8d2@oss.qualcomm.com>
In-Reply-To: <20260521-pdev-fwnode-ref-v1-6-88c324a1b8d2@oss.qualcomm.com>
References: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> <20260521-pdev-fwnode-ref-v1-6-88c324a1b8d2@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Introduces the primary helper. Implementation is clean:

```c
void platform_device_set_of_node(struct platform_device *pdev,
				 struct device_node *np)
{
	of_node_put(pdev->dev.of_node);
	pdev->dev.of_node =3D of_node_get(np);
	pdev->dev.fwnode =3D of_fwnode_handle(np);
}
```

The `of_node_put()` of the old node is good =E2=80=94 it makes the function=
 safe to call multiple times (idempotent assignment). Setting `fwnode` alon=
gside `of_node` is important since they must stay in sync. No issues.

---
Generated by Claude Code Patch Reviewer