From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 10.1" DSI Date: Mon, 25 May 2026 19:56:39 +1000 Message-ID: In-Reply-To: <20260521150038.103538-23-ivitro@gmail.com> References: <20260521150038.103538-17-ivitro@gmail.com> <20260521150038.103538-23-ivitro@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review DSI overlay using `ti,sn65dsi83` bridge with Riverdi panel and ILI2132 touc= h. **Observation**: This uses `ti,sn65dsi83` (the DSI83, single LVDS channel) = while Patch 2 uses `ti,sn65dsi84` (the DSI84, dual LVDS support). This is c= orrect =E2=80=94 the 10.1" DSI display module contains a DSI83, while the s= tandalone adapter uses a DSI84. The touch controller uses `IRQ_TYPE_EDGE_RISING` for `ilitek,ili2132` =E2= =80=94 verify this matches the ILI2132 datasheet. The MaxTouch in patches 2= /3 uses `IRQ_TYPE_EDGE_FALLING`. Different controllers can have different i= nterrupt polarities, but this should be verified. --- Generated by Claude Code Patch Reviewer