From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: Act on the DRM color format property Date: Mon, 25 May 2026 18:48:54 +1000 Message-ID: In-Reply-To: <20260522-color-format-v15-6-21fb136c9df2@collabora.com> References: <20260522-color-format-v15-0-21fb136c9df2@collabora.com> <20260522-color-format-v15-6-21fb136c9df2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The `bus_format_is_color_fmt()` function is well-structured and covers the = right set of media bus formats. The `__pure` annotation is correct since it= depends only on parameters. One concern: when all output bus formats are rejected by color format filte= ring, `ret` is left as `-ENOTSUPP` from the last iteration. This is correct= behavior =E2=80=94 the caller will see it as "no format worked" =E2=80=94 = but the debug message could be confusing since it only logs "Skipping" with= out a final "No matching format found" message. The `MEDIA_BUS_FMT_FIXED` always returning `true` regardless of requested f= ormat is correct =E2=80=94 FIXED means "don't care about format", so any re= quest should be accepted. --- Generated by Claude Code Patch Reviewer