From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: writeback: Modify prepare_writeback_job helper Date: Mon, 25 May 2026 19:19:16 +1000 Message-ID: In-Reply-To: <20260522050313.1800378-7-suraj.kandpal@intel.com> References: <20260522050313.1800378-1-suraj.kandpal@intel.com> <20260522050313.1800378-7-suraj.kandpal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Changes the `prepare_writeback_job` callback in `struct drm_connector_helper_funcs` from taking `struct drm_writeback_connector *` to `struct drm_connector *`. **Analysis:** Correct. All driver implementations updated. The rcar-du driver nicely simplifies: ```c -static int rcar_du_wb_prepare_job(struct drm_writeback_connector *connector, +static int rcar_du_wb_prepare_job(struct drm_connector *connector, struct drm_writeback_job *job) { - struct drm_connector *conn = drm_writeback_to_connector(connector); - struct rcar_du_crtc *rcrtc = wb_to_rcar_crtc(conn); + struct rcar_du_crtc *rcrtc = wb_to_rcar_crtc(connector); ``` The `drm_writeback_prepare_job()` caller in `drm_writeback.c` is also updated correctly. Note: in patch 1, `drm_writeback_prepare_job()` was modified to get the connector via `drm_writeback_to_connector()`, and here it passes that connector to the callback. The flow is consistent. --- Generated by Claude Code Patch Reviewer