From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: Add a6xx+ perfcntr tables Date: Mon, 25 May 2026 18:21:39 +1000 Message-ID: In-Reply-To: <20260522173349.55491-7-robin.clark@oss.qualcomm.com> References: <20260522173349.55491-1-robin.clark@oss.qualcomm.com> <20260522173349.55491-7-robin.clark@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The family range checks in `a6xx_gpu_init` are clear: ```c if ((ADRENO_6XX_GEN1 <= config->info->family) && (config->info->family <= ADRENO_6XX_GEN4)) { ``` This approach means new families added beyond `ADRENO_8XX_GEN2` would silently have no perfcntr support. That's a reasonable default (fail-safe) rather than fail-open, but worth noting for future GPU bring-up. --- Generated by Claude Code Patch Reviewer