From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: Act on the DRM color format property Date: Mon, 25 May 2026 17:26:09 +1000 Message-ID: In-Reply-To: <20260523-color-format-v16-6-24340c5e4732@collabora.com> References: <20260523-color-format-v16-0-24340c5e4732@collabora.com> <20260523-color-format-v16-6-24340c5e4732@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The `bus_format_is_color_fmt()` function is comprehensive and correctly cov= ers all the media bus format variants for each color format family. The `__= pure` annotation is appropriate. **Minor note:** The function returns `false` for unknown bus formats in the= `default:` case when a specific format is requested. This means any future= bus format additions would silently be rejected until they're added to thi= s function. Acceptable, but worth noting. The integration into `drm_atomic_bridge_chain_select_bus_fmts()` is clean = =E2=80=94 skipping non-matching formats with `continue` and letting `ret = =3D -ENOTSUPP` persist until a match is found is the right approach. --- Generated by Claude Code Patch Reviewer