From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: drm: nova: build after nova-core metadata Date: Thu, 28 May 2026 12:22:00 +1000 Message-ID: In-Reply-To: <20260527-nova-exports-v2-6-06de4c556d55@nvidia.com> References: <20260527-nova-exports-v2-0-06de4c556d55@nvidia.com> <20260527-nova-exports-v2-6-06de4c556d55@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Wires up `nova-drm`'s Makefile to depend on `nova-core`'s metadata: ```makefile rustflags-y +=3D --extern nova_core=3D$(objtree)/$(nova_core_rmeta) $(obj)/nova.o: | $(objtree)/$(nova_core_rmeta) $(objtree)/$(nova_core_rmeta): FORCE $(Q)$(MAKE) $(build)=3Ddrivers/gpu/nova-core $(nova_core_rmeta) ``` The order-only prerequisite (`|`) is correct =E2=80=94 `nova.o` needs the m= etadata to exist before compilation starts, but doesn't need to be rebuilt = just because the metadata timestamp changed (rustc will check content). The recursive `$(MAKE)` call to build `nova-core`'s metadata from `nova-drm= `'s Makefile is explicitly acknowledged as ugly but temporary. **No issues.** --- Generated by Claude Code Patch Reviewer