From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: meson: vdec: Configure DMA mask and segment size in probe Date: Thu, 04 Jun 2026 15:48:47 +1000 Message-ID: In-Reply-To: <20260530094326.11892-7-linux.amoon@gmail.com> References: <20260530094326.11892-1-linux.amoon@gmail.com> <20260530094326.11892-7-linux.amoon@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Questionable =E2=80=94 64-bit DMA mask for Amlogic SoCs:** Setting `DMA_B= IT_MASK(64)` is unusual for these SoCs. Amlogic Meson GX/G12A SoCs typicall= y have 32-bit address spaces for their peripherals. A 64-bit DMA mask might= silently work if the IOMMU or swiotlb handles it, but it's misleading. The= correct mask depends on the actual hardware capability. Most Amlogic drive= rs use 32-bit masks or rely on the default. Consider using `DMA_BIT_MASK(32= )`. **Minor:** `vb2_dma_contig_set_max_seg_size()` is fine, this is common prac= tice for V4L2 drivers. **Missing cleanup:** `vb2_dma_contig_set_max_seg_size()` allocates `dev->dm= a_parms` via `kzalloc`, and there's no corresponding `vb2_dma_contig_clear_= max_seg_size()` call in `vdec_remove()`. --- Generated by Claude Code Patch Reviewer