From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/meson: Open-code drm_simple_encoder_init() in encoder_dsi Date: Thu, 04 Jun 2026 15:05:01 +1000 Message-ID: In-Reply-To: <20260531074627.8936-3-namanarora029@gmail.com> References: <20260531073532.8609-1-namanarora029@gmail.com> <20260531074627.8936-3-namanarora029@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correctness: OK** Same pattern. `meson_encoder_dsi_drm_encoder_funcs` is correctly defined. Encoder type `DRM_MODE_ENCODER_DSI` is preserved. **Minor nit on include ordering:** After removing `drm_simple_kms_helper.h`, the remaining includes have `drm_atomic_helper.h` followed by `drm_bridge.h`. The original had `drm_simple_kms_helper.h` between `drm_atomic_helper.h` and `drm_bridge.h`. The resulting order is still alphabetical, so this is fine. Reviewed-by worthy. --- Generated by Claude Code Patch Reviewer