From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Allow backlight registration to fail Date: Thu, 04 Jun 2026 14:54:31 +1000 Message-ID: In-Reply-To: <20260531114908.1693426-7-superm1@kernel.org> References: <20260531114908.1693426-1-superm1@kernel.org> <20260531114908.1693426-7-superm1@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Concern: Failing connector late_register on backlight failure** ```c - amdgpu_dm_register_backlight_device(amdgpu_dm_connector); + r =3D amdgpu_dm_register_backlight_device(amdgpu_dm_connector); + if (r) + return r; ``` If backlight registration fails, the entire connector late_register fails. = This will prevent the connector from being usable at all, even though the d= isplay itself works fine =E2=80=94 only backlight control is broken. This s= eems too aggressive. A warning + continue would be more appropriate for a n= on-critical feature like backlight. --- Generated by Claude Code Patch Reviewer