From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: hdmi_state_helper: Plumb HDMI 2.0 source scrambling capability Date: Thu, 04 Jun 2026 13:33:48 +1000 Message-ID: In-Reply-To: <20260602-dw-hdmi-qp-scramb-v7-6-445eb54ee1ed@collabora.com> References: <20260602-dw-hdmi-qp-scramb-v7-0-445eb54ee1ed@collabora.com> <20260602-dw-hdmi-qp-scramb-v7-6-445eb54ee1ed@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The `scrambler_needed` computation is correct per HDMI 2.0: mandatory above 340 MHz, not requested below. The TODO about rejecting unsupported modes is appropriate. One subtlety: `scrambler_needed` is set inside `hdmi_compute_clock()` which runs during atomic check. If the check runs multiple times (BPC fallback), the flag will be overwritten each time. Since it's set based on the final `clock` value that also determines `tmds_char_rate`, this is correct. --- Generated by Claude Code Patch Reviewer