From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Reject invalid syncobj handles in submit ioctls Date: Thu, 04 Jun 2026 11:24:40 +1000 Message-ID: In-Reply-To: <20260603-v3d-sched-misc-fixes-v3-6-d7114bba55a0@igalia.com> References: <20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com> <20260603-v3d-sched-misc-fixes-v3-6-d7114bba55a0@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good fix. Previously, `-ENOENT` from `drm_sched_job_add_syncobj_dependency()` was silently swallowed for both zero handles (reasonable: no dependency) and invalid non-zero handles (userspace bug that should be reported). The patch distinguishes the two: skip the call when handle is zero, propagate the error otherwise. Removes the TODO comments. Reviewed-by: Tvrtko Ursulin. No issues. --- Generated by Claude Code Patch Reviewer