From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: hamoa: Add inline crypto for UFS Date: Sat, 16 May 2026 09:57:53 +1000 Message-ID: In-Reply-To: <30c12b79c6cc481afb13ac93630c5a16bc856ae4.1778822464.git.harrison.vanderbyl@gmail.com> References: <30c12b79c6cc481afb13ac93630c5a16bc856ae4.1778822464.git.harrison.vanderbyl@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds the ICE node and wires it to the UFS host controller in the shared ham= oa.dtsi: ```dts + ice: crypto@1d88000 { + compatible =3D "qcom,x1e80100-inline-crypto-engine", + "qcom,inline-crypto-engine"; + reg =3D <0x0 0x01d88000 0x0 0x8000>; + + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + }; ``` The `qcom,ice` property is added to the UFS node: ```dts + qcom,ice =3D <&ice>; ``` The ICE node address `0x1d88000` is correctly placed before `cryptobam` at = `0x1dc4000` in ascending address order. The compatible uses the binding fro= m patch 2/7. This affects all hamoa-based boards (x1e80100 family), which i= s intentional since the ICE hardware is part of the SoC. **Potential concern:** This change affects the shared `hamoa.dtsi` which is= used by all x1e80100/x1p42100 boards. Adding `qcom,ice` to the UFS node an= d a new ICE device node will affect existing boards (Surface Pro 11 / Denal= i, Lenovo ThinkPad, ASUS VivoBook, etc.). This should be fine since the ICE= hardware exists on all these SoCs =E2=80=94 but it would be good to confir= m this doesn't break any existing boards. The ICE node has no `status` prop= erty so it defaults to "okay", and the `qcom,ice` property in the UFS node = is optional in the driver. This should be safe. --- --- Generated by Claude Code Patch Reviewer