From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: drm: mediatek: ovl: add specific entry for mt8167
Date: Tue, 24 Feb 2026 10:06:13 +1000 [thread overview]
Message-ID: <review-patch6-5f880f1334aa93184afee3e36132ca42628821fb.1771863641.git.l.scorcia@gmail.com> (raw)
In-Reply-To: <5f880f1334aa93184afee3e36132ca42628821fb.1771863641.git.l.scorcia@gmail.com>
Patch Review
No issues found. The new `mt8167_ovl_driver_data` is identical to `mt8173_ovl_driver_data` except for `smi_id_en = true`:
> +static const struct mtk_disp_ovl_data mt8167_ovl_driver_data = {
> + .addr = DISP_REG_OVL_ADDR_MT8173,
> + .gmc_bits = 8,
> + .layer_nr = 4,
> + .fmt_rgb565_is_0 = true,
> + .smi_id_en = true,
> + .formats = mt8173_formats,
> + .num_formats = ARRAY_SIZE(mt8173_formats),
> +};
This is the correct approach -- creating a separate driver data struct rather than trying to reuse mt8173's, since the `smi_id_en` difference is a real hardware distinction. The commit message appropriately cites Android kernel sources as the reference for this requirement. Already has a Reviewed-by from AngeloGioacchino Del Regno.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-24 0:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 16:22 [PATCH v3 0/6] Add support for mt8167 display blocks Luca Leonardo Scorcia
2026-02-23 16:22 ` [PATCH v3 1/6] arm64: dts: mt8167: Reorder nodes according to mmio address Luca Leonardo Scorcia
2026-02-24 0:06 ` Claude review: " Claude Code Review Bot
2026-02-23 16:22 ` [PATCH v3 2/6] dt-bindings: display: mediatek: Add compatibles for MediaTek mt8167 Luca Leonardo Scorcia
2026-02-24 0:06 ` Claude review: " Claude Code Review Bot
2026-02-23 16:22 ` [PATCH v3 3/6] dt-bindings: phy: mediatek, dsi-phy: Add support for mt8167 Luca Leonardo Scorcia
2026-02-24 0:06 ` Claude review: " Claude Code Review Bot
2026-02-23 16:22 ` [PATCH v3 4/6] arm64: dts: mediatek: mt8167: Add DRM nodes Luca Leonardo Scorcia
2026-02-24 0:06 ` Claude review: " Claude Code Review Bot
2026-02-23 16:22 ` [PATCH v3 5/6] drm/mediatek: dsi: Add compatible for mt8167-dsi Luca Leonardo Scorcia
2026-02-23 16:39 ` AngeloGioacchino Del Regno
2026-02-24 0:06 ` Claude review: " Claude Code Review Bot
2026-02-23 16:22 ` [PATCH v3 6/6] gpu: drm: mediatek: ovl: add specific entry for mt8167 Luca Leonardo Scorcia
2026-02-24 0:06 ` Claude Code Review Bot [this message]
2026-02-24 0:06 ` Claude review: Add support for mt8167 display blocks Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-5f880f1334aa93184afee3e36132ca42628821fb.1771863641.git.l.scorcia@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox