From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: drm: mediatek: ovl: add specific entry for mt8167 Date: Tue, 24 Feb 2026 10:06:13 +1000 Message-ID: In-Reply-To: <5f880f1334aa93184afee3e36132ca42628821fb.1771863641.git.l.scorcia@gmail.com> References: <5f880f1334aa93184afee3e36132ca42628821fb.1771863641.git.l.scorcia@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review No issues found. The new `mt8167_ovl_driver_data` is identical to `mt8173_ovl_driver_data` except for `smi_id_en = true`: > +static const struct mtk_disp_ovl_data mt8167_ovl_driver_data = { > + .addr = DISP_REG_OVL_ADDR_MT8173, > + .gmc_bits = 8, > + .layer_nr = 4, > + .fmt_rgb565_is_0 = true, > + .smi_id_en = true, > + .formats = mt8173_formats, > + .num_formats = ARRAY_SIZE(mt8173_formats), > +}; This is the correct approach -- creating a separate driver data struct rather than trying to reuse mt8173's, since the `smi_id_en` difference is a real hardware distinction. The commit message appropriately cites Android kernel sources as the reference for this requirement. Already has a Reviewed-by from AngeloGioacchino Del Regno. --- Generated by Claude Code Patch Reviewer