From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH 61/61] file: Drop unlikely() around IS_ERR_OR_NULL() Date: Thu, 12 Mar 2026 07:27:21 +1000 Message-ID: In-Reply-To: <2ff39929dad06ca7d009ccd6dfe873da22a07c8a.camel@kernel.org> References: <2ff39929dad06ca7d009ccd6dfe873da22a07c8a.camel@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Same =E2=80=94 correct removal of redundant `unlikely()`. ### Remaining patches (03, 06, 08-09, 11-13, 17-21, 23-25, 27-28, 30, 32, 3= 4-36, 39-41, 43, 45-54) These are all straightforward mechanical `ptr && !IS_ERR(ptr)` =E2=86=92 `!= IS_ERR_OR_NULL(ptr)` or `!ptr || IS_ERR(ptr)` =E2=86=92 `IS_ERR_OR_NULL(ptr= )` transformations with no semantic changes. They are correct. **Summary of actionable issues:** - **Drop or rework patches 55-58** (WARN_ON semantic changes) =E2=80=94 the= se add false-positive warnings for legitimate NULL usage patterns - Fix the `IF_ERR_OR_NULL` typo in the coccinelle script comment (patch 01) - Fix "NULl" typo in patch 05 subject, "Semantich" in patch 57, "cottect" i= n patch 01 - Note the `unlikely()` removal in patch 02 (btrfs/transaction.c) in the co= mmit message --- Generated by Claude Code Patch Reviewer