From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm_print: fix drm_printer dynamic debug bypass Date: Sat, 14 Mar 2026 07:00:31 +1000 Message-ID: In-Reply-To: <20260313132103.2529746-65-jim.cromie@gmail.com> References: <20260313132103.2529746-1-jim.cromie@gmail.com> <20260313132103.2529746-65-jim.cromie@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Important fix.** With `CONFIG_DRM_USE_DYNAMIC_DEBUG`, `__drm_debug_enable= d()` expands to `true`, so `__drm_printfn_dbg()` (a callback, not guarded b= y a dyndbg static key) would print unconditionally, causing UART storms. Th= e fix changes to `drm_debug_enabled_instrumented()`. **Concern:** `drm_debug_enabled_instrumented()` includes a `pr_debug("todo:= is this frequent enough to optimize ?\n")` instrumentation probe. In a hig= h-frequency callback path, this adds overhead and noise when pr_debug is en= abled. `drm_debug_enabled_raw()` would be more appropriate for a production= fix =E2=80=94 it does the actual bit-test without the instrumentation prob= e. --- Generated by Claude Code Patch Reviewer